Django security releases issued: 2.2.8 and 2.1.15
In accordance with our security release policy, the Django team is issuing Django 2.2.8 and Django 2.1.15. These release addresses the security issue detailed below. We encourage all users of Django to upgrade as soon as possible.
CVE-2019-19118: Privilege escalation in the Django admin.
Since Django 2.1, a Django model admin displaying a parent model with related model inlines, where the user has view-only permissions to a parent model but edit permissions to the inline model, would display a read-only view of the parent model but editable forms for the inline.
Submitting these forms would not allow direct edits to the parent model, but would trigger the parent model's save() method, and cause pre and post-save signal handlers to be invoked. This is a privilege escalation as a user who lacks permission to edit a model should not be able to trigger its save-related signals.
To resolve this issue, the permission handling code of the Django admin interface has been changed. Now, if a user has only the "view" permission for a parent model, the entire displayed form will not be editable, even if the user has permission to edit models included in inlines.
This is a backwards-incompatible change, and the Django security team is aware that some users of Django were depending on the ability to allow editing of inlines in the admin form of an otherwise view-only parent model.
Given the complexity of the Django admin, and in-particular the permissions related checks, it is the view of the Django security team that this change was necessary: that it is not currently feasible to maintain the existing behavior whilst escaping the potential privilege escalation in a way that would avoid a recurrence of similar issues in the future, and that would be compatible with Django's safe by default philosophy.
For the time being, developers whose applications are affected by this change should replace the use of inlines in read-only parents with custom forms and views that explicitly implement the desired functionality. In the longer term, adding a documented, supported, and properly-tested mechanism for partially-editable multi-model forms to the admin interface may occur in Django itself.
Thank you to Shen Ying for reporting this issue.
Affected supported versions
- Django master branch
- Django 3.0 (which will be released in a separate blog post later today)
- Django 2.2
- Django 2.1
Patches to resolve the issue have been applied to Django's master branch and the 3.0, 2.2, and 2.1 release branches. The patches may be obtained from the following changesets:
- On the master branch
- On the 3.0 release branch
- On the 2.2 release branch
- On the 2.1 release branch
The following releases have been issued:
- Django 2.2.8 (download Django 2.2.8 | 2.2.8 checksums)
- Django 2.1.15 (download Django 2.1.15 | 2.1.15 checksums)
The PGP key ID used for these releases is Carlton Gibson: E17DF5C82B4F9D00.
General notes regarding security reporting
As always, we ask that potential security issues be reported via private email to firstname.lastname@example.org, and not via Django's Trac instance or the django-developers list. Please see our security policies for further information.